feat(sdk): Adds BSC to RFQ #2830
Conversation
WalkthroughThe overall changes introduce support for the Binance Smart Chain (BSC) in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
packages/sdk-router/src/constants/chainIds.ts (1)
Line range hint
35-35: UseNumber.isNaNinstead ofisNaN.
isNaNattempts a type coercion. UseNumber.isNaNfor safety.- .filter((chainId) => !isNaN(chainId)) + .filter((chainId) => !Number.isNaN(chainId))
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- packages/sdk-router/src/constants/chainIds.ts (1 hunks)
- packages/sdk-router/src/constants/medianTime.ts (1 hunks)
Additional context used
Biome
packages/sdk-router/src/constants/chainIds.ts
[error] 35-35: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.(lint/suspicious/noGlobalIsNan)
Additional comments not posted (2)
packages/sdk-router/src/constants/medianTime.ts (1)
54-54: LGTM!The addition of
SupportedChainId.BSCto theMEDIAN_TIME_RFQconstant is correct and consistent with the format used in the file.packages/sdk-router/src/constants/chainIds.ts (1)
64-64: LGTM!The addition of
SupportedChainId.BSCto theRFQ_SUPPORTED_CHAIN_IDSarray is correct and consistent with the format used in the file.
Deploying sanguine-fe with
|
| Latest commit: |
6fe2406
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72f71de1.sanguine-fe.pages.dev |
| Branch Preview URL: | https://sdk-adds-bsc.sanguine-fe.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/sdk-router/src/sdk.test.ts (2 hunks)
Additional comments not posted (4)
packages/sdk-router/src/sdk.test.ts (4)
923-924: Verify the context of changes.The initialization of
SynapseSDKwith ETH and ARBITRUM doesn't directly relate to the added BSC support. Ensure this change aligns with the overall PR objectives.
986-988: LGTM!The test case correctly ensures that
bridgeQuotethrows an error when the amount is too low, maintaining the robustness of the SDK.
923-924: Verify the context of changes.The initialization of
SynapseSDKwith ETH and ARBITRUM doesn't directly relate to the added BSC support. Ensure this change aligns with the overall PR objectives.
986-988: LGTM!The test case correctly ensures that
bridgeQuotethrows an error when the amount is too low, maintaining the robustness of the SDK.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2830 +/- ##
=============================================
Coverage 23.57546% 23.57546%
=============================================
Files 679 679
Lines 50841 50841
Branches 80 80
=============================================
Hits 11986 11986
Misses 37533 37533
Partials 1322 1322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abtestingalpha
force-pushed
the
sdk/adds-bsc
branch
from
5630920 to
6fe2406
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- packages/sdk-router/src/constants/chainIds.ts (1 hunks)
- packages/sdk-router/src/constants/medianTime.ts (1 hunks)
- packages/sdk-router/src/sdk.test.ts (2 hunks)
Additional comments not posted (3)
packages/sdk-router/src/constants/medianTime.ts (1)
54-54: Addition of BSC toMEDIAN_TIME_RFQis CorrectThe addition of
[SupportedChainId.BSC]: 15follows the existing structure and is syntactically correct.packages/sdk-router/src/constants/chainIds.ts (1)
64-64: Addition of BSC toRFQ_SUPPORTED_CHAIN_IDSis CorrectThe addition of
SupportedChainId.BSCfollows the existing structure and is syntactically correct.packages/sdk-router/src/sdk.test.ts (1)
923-924: Update of Supported Chain from BSC to ARBITRUM is CorrectThe supported chain has been updated from
SupportedChainId.BSCtoSupportedChainId.ARBITRUM, and the corresponding providers have been updated accordingly. This change is syntactically correct and consistent with the test's objectives.
Bundle ReportChanges will decrease total bundle size by 7.17MB ⬇️
|
abtestingalpha
requested review from
aureliusbtc,
ChiTimesChi and
trajan0x
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added Binance Smart Chain (BSC) to
RFQ_SUPPORTED_CHAIN_IDSin/packages/sdk-router/src/constants/chainIds.ts - Set median RFQ transaction time for BSC to 15 seconds in
/packages/sdk-router/src/constants/medianTime.ts - Updated test configurations to use Arbitrum instead of BSC in
/packages/sdk-router/src/sdk.test.ts
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Summary by CodeRabbit
New Features
Updates
Tests